Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to load all permission filters at the permissions list page #1306

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Allow to load all permission filters at the permissions list page #1306

merged 2 commits into from
Apr 24, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Apr 24, 2019

Add a permissions filter filter for permission list page

Checklist:

@bjoernricks bjoernricks marked this pull request as ready for review April 24, 2019 12:52
@bjoernricks bjoernricks requested a review from a team April 24, 2019 12:52
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1306 into gsa-8.0 will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           gsa-8.0    #1306      +/-   ##
===========================================
+ Coverage    18.09%   18.09%   +<.01%     
===========================================
  Files          953      953              
  Lines        27723    27725       +2     
  Branches      5994     5994              
===========================================
+ Hits          5016     5017       +1     
- Misses       21302    21303       +1     
  Partials      1405     1405
Impacted Files Coverage Δ
gsa/src/web/pages/permissions/listpage.js 0% <0%> (ø) ⬆️
gsa/src/gmp/models/filter.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a41cd8...d21dbb8. Read the comment docs.

@swaterkamp swaterkamp merged commit 3cb791e into greenbone:gsa-8.0 Apr 24, 2019
@bjoernricks bjoernricks deleted the fix-permission-filter-loading branch May 3, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants